Fixup DashBasePlotsExt
#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add tests for `DashBasePlotlyBaseExt` and `DashBasePlotlyJSExt` - all `DashBase.to_dash` method should return the same object after one call as `to_dash` is not called recursively. See <https://github.com/plotly/Dash.jl/blob/d01ce73b4667991f3441e167816fd00a24a35a54/src/handler/processors/callback.jl#L29> - these new tests currently fail for both the `Plots`'s `plotly()` and `plotlyjs()` renderers.
so that they return `Dict`s, fixing potential infinite loop within `JSON3.write` calls
|
Hmm, not sure why Julia 1.8 doesn't like |
|
I think it might be a problem with the latest PackageExtensionCompat release with diff --git a/Project.toml b/Project.toml
index 51efcbe..e65541f 100644
--- a/Project.toml
+++ b/Project.toml
@@ -23,7 +23,7 @@ Plots = "1"
julia = "1.6"
PlotlyBase = "0.8"
PlotlyJS = "0.18"
-PackageExtensionCompat = "1"
+PackageExtensionCompat = "=1.0.0"the tests are passing fine with Julia 1.8.5 see test logs |
using `Requires` dance as suggested by https://pkgdocs.julialang.org/v1.9/creating-packages/#Requires.jl
Replace with `PackageExtensionCompat`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Dash.jl callback source,
DashBase.to_dashis called once and is not part of a customJSON3.StructTypes.lowerdefinition.So,
DashBase.to_dashis expected to return the same type after one call for all its methods.If not,
JSON3.writecan run into infinite loops. Considerwith
[email protected]and the currentDashBase#master(with the #4 merge commit as HEAD), we get